Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

feat: Propagate git commit ID for sequence in CloudEvent context #374

Merged
merged 1 commit into from
Jan 18, 2022
Merged

feat: Propagate git commit ID for sequence in CloudEvent context #374

merged 1 commit into from
Jan 18, 2022

Conversation

odubajDT
Copy link
Contributor

@odubajDT odubajDT commented Jan 10, 2022 •
edited
Loading

Signed-off-by: odubajDT [email protected]

This PR

  • propagates git commit ID for sequence in CloudEvent context

Related Issues

Fixes keptn/keptn#6347

github-actions[bot]
github-actions bot reviewed Jan 10, 2022
View reviewed changes
pkg/lib/v0_2_0/events.go Outdated Show resolved Hide resolved
pkg/lib/v0_2_0/keptn.go Outdated Show resolved Hide resolved
oleg-nenashev
oleg-nenashev previously approved these changes Jan 10, 2022
View reviewed changes
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@odubajDT odubajDT force-pushed the feat/6347/add-gitCommitId-to-cloudevent branch from 0a76125 to 4e1eff7 Compare January 10, 2022 11:26
@sonarcloud
Copy link

sonarcloud bot commented Jan 10, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@odubajDT
Copy link
Contributor Author

According to discussion with @thisthat this PR should not be merged for Keptn 0.12, as it is a breaking change. We are aiming this for Keptn 0.13

@odubajDT odubajDT mentioned this pull request Jan 10, 2022
Merged
RealAnna
RealAnna approved these changes Jan 18, 2022
View reviewed changes
Copy link
Contributor

@RealAnna RealAnna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and we can merge now :)

@odubajDT odubajDT merged commit fa37290 into master Jan 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@RealAnna RealAnna RealAnna approved these changes

@oleg-nenashev oleg-nenashev oleg-nenashev left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CloudEvents: Propagate git commit ID for sequence in CloudEvent context
3 participants
@odubajDT @oleg-nenashev @RealAnna